Pass user object to submitDeclaration method

- Add user parameter to submitDeclaration method signature
- Pass user object from view file to submitDeclaration method
- Remove redundant global user declaration
- Fixes null user parameter in bookkeeping create method

core/class/declarationtva.class.php

@@ -1290,12 +1290,11 @@ class DeclarationTVA
      * Submit declaration (create accounting entries and update status)
      *
      * @param int $declaration_id Declaration ID
+     * @param object $user User object
      * @return bool Success
      */
-    public function submitDeclaration($declaration_id)
+    public function submitDeclaration($declaration_id, $user)
     {
-        global $user;
-        
         // Get declaration data
         $declaration = $this->fetch($declaration_id);
         if (!$declaration) {

declarationtva_view.php

@@ -114,7 +114,7 @@ if ($action == 'unvalidate' && $token) {
 
 if ($action == 'submit' && $token) {
     // Submit the declaration (create accounting entries and update status)
-    if ($declarationtva->submitDeclaration($id)) {
+    if ($declarationtva->submitDeclaration($id, $user)) {
         setEventMessages($langs->trans("DeclarationSubmitted"), null, 'mesgs');
     } else {
         setEventMessages($langs->trans("ErrorSubmittingDeclaration") . ": " . $declarationtva->error, null, 'errors');